Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmd.FullName in metrics attributes #2872

Open
2011aad opened this issue Jan 23, 2024 · 0 comments · May be fixed by #3050
Open

Add cmd.FullName in metrics attributes #2872

2011aad opened this issue Jan 23, 2024 · 0 comments · May be fixed by #3050

Comments

@2011aad
Copy link

2011aad commented Jan 23, 2024

Issue tracker is used for reporting bugs and discussing new features. Please use
stackoverflow for supporting issues.

Adding a cmd name attribute is useful for monitoring application accessing redis, because different kinds of cmd may perform differently.

Expected Behavior

Expect adding cmd name (get/set/del etc.) in metrics attributes.

Current Behavior

Currently, only type:command attribute is added to the metrics.

Possible Implementation

Add the following code in ProcessHook function of metricsHook.

attrs = append(attrs, attribute.String("cmd", cmd.FullName()))
@KyleKincer KyleKincer linked a pull request Jul 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add command name to metrics KyleKincer/go-redis
1 participant
@2011aad