Allow setting golang executable from environment variable #89
Conversation
This commit makes it easier to use different go versions for running the commands in the Makefile Signed-off-by: Divyansh Kamboj <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weirdwiz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PTAL @vbnrh @umangachapagain It's a small QOL commit. |
| @@ -1,6 +1,8 @@ | |||
| PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST)))) | |||
| CWD := $(shell pwd) | |||
|
|
|||
| GO ?= go | |||
There was a problem hiding this comment.
using different versions can cause unwanted confusion (for example go.mod/go.sum gets generated differently with 1.16 and 1.17) . best option is to stick to the required versions
There was a problem hiding this comment.
Yes, but the default behavior will remain the same nonetheless. But sometimes we might need to test out multiple golang executable, usually when updating dependencies.
There was a problem hiding this comment.
Can't we temporarily set PATH and test it?
|
@weirdwiz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This will help us to easily use different golang versions in the Makefile. Usually required to test out dependency upgrades.
Eg: