Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-961: [release-4.18] Fix issue with the hash generation for MirrorPeer #247

Merged
merged 1 commit into from
Dec 9, 2024
Merged

DFBUGS-961: [release-4.18] Fix issue with the hash generation for MirrorPeer #247

merged 1 commit into from
Dec 9, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #245

/assign vbnrh

@vbnrh
Fix issue with the hash generation for MirrorPeer
d433113 
There are two separate methods to generate hashes based on whether
RDR is done for provider mode or internal mode

The one for internal mode is being reverted in this commit as the
it was causing issues with upgrades

Signed-off-by: vbadrina <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 9, 2024
Merged
@vbnrh
Copy link
Member

vbnrh commented Dec 9, 2024 •
edited by openshift-ci bot
Loading

/retitle DFBUGS-961 [release-4.18] Fix issue with the hash generation for MirrorPeer

@openshift-ci openshift-ci bot changed the title [release-4.18] Fix issue with the hash generation for MirrorPeer DFBUGS-961 [release-4.18] Fix issue with the hash generation for MirrorPeer Dec 9, 2024
@vbnrh
Copy link
Member

vbnrh commented Dec 9, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 9, 2024
@agarwal-mudit agarwal-mudit changed the title DFBUGS-961 [release-4.18] Fix issue with the hash generation for MirrorPeer DFBUGS-961: [release-4.18] Fix issue with the hash generation for MirrorPeer Dec 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-961](https://issues.redhat.com//browse/DFBUGS-961), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #245

/assign vbnrh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agarwal-mudit
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2024 •
edited by openshift-ci bot
Loading

@agarwal-mudit: This pull request references [Jira Issue DFBUGS-961](https://issues.redhat.com//browse/DFBUGS-961), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 004d184 into red-hat-storage:release-4.18 Dec 9, 2024
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: [Jira Issue DFBUGS-961](https://issues.redhat.com//browse/DFBUGS-961): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-961](https://issues.redhat.com//browse/DFBUGS-961) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #245

/assign vbnrh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vbnrh vbnrh

Labels
approved jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @vbnrh @openshift-ci-robot @agarwal-mudit