-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-911: [release-4.18] Labels volumesnapshot class with storageid #243
DFBUGS-911: [release-4.18] Labels volumesnapshot class with storageid #243
Conversation
This commit labels all rbd and cephfs storageclasses and associated volumesnapshotclasses with storageid. Also adds storageid label to the volumereplication class being created The implementation is moved to work for both MDR and RDR scenarios Signed-off-by: vbadrina <[email protected]>
/retitle DFBUGS-911 [release-4.18] Labels volumesnapshot class with storageid |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@vbnrh: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retitle DFBUGS-911: [release-4.18] Labels volumesnapshot class with storageid |
@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-911](https://issues.redhat.com//browse/DFBUGS-911), which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
c8dc953
into
red-hat-storage:release-4.18
@openshift-cherrypick-robot: [Jira Issue DFBUGS-911](https://issues.redhat.com//browse/DFBUGS-911): All pull requests linked via external trackers have merged: [Jira Issue DFBUGS-911](https://issues.redhat.com//browse/DFBUGS-911) has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is an automated cherry-pick of #240
/assign vbnrh