Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip if resources are not found on the agents #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

weirdwiz
Copy link
Contributor

@weirdwiz weirdwiz commented May 5, 2022

this commit adds logic to continue with deletion if the it's trying to
delete are not found
Signed-off-by: Divyansh Kamboj [email protected]

this commit adds logic to continue with deletion if the it's trying to
delete are not found
Signed-off-by: Divyansh Kamboj <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weirdwiz
To complete the pull request process, please assign vbnrh after the PR has been reviewed.
You can assign the PR to them by writing /assign @vbnrh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like these functions could be called even during installation. These NotFound errors are important errors that needs to be returned. When user tries to enable mirroring on a storagecluster that doesn't exist, we need to report that as error.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants