Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Sync (master & release-4.18) #1700

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Manual Sync (master & release-4.18) #1700

merged 10 commits into from
Nov 21, 2024

Conversation

SanjalKatiyar
Copy link
Collaborator

No description provided.

alfonsomthd and others added 10 commits November 19, 2024 17:29
DFBUGS-867: [RDR] UI blocks a DR operation on an appset based workload
The configurations for In-Transit Encryption in external mode are all
required to be done on the RHCS cluster by the ceph admin. Ticking the
checkbox on ODF side only sets the kernel mount option for cephFS.
So it might be misleading the user to think, the checkbox is enough to
enable Eit in external mode. So added an info alert under the checkbox
to clarify that settings need to be applied on the RHCS cluster. Also
reworded the description of the checkbox to make it more clear to the
user.

Signed-off-by: Malay Kumar Parida <[email protected]>
Add info alert for In-transit Encryption in external mode
Enable lint rules for naming conventions
@bipuladh
Copy link
Contributor

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ec0a05e into release-4.18 Nov 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants