Storagecluster Reconciling not working accurate

[parth-gr]

There was a bug in creating a storagecluster but the reconciler updated it correctly in next reconcile, which is not the correct behaviour

Reconciler should not send positive signal to operator unless it is succeed

{"level":"error","ts":"2023-11-27T18:36:35Z","logger":"controllers.StorageCluster","msg":"Could not create ExternalStorageClusterResource.","Request.Namespace":"openshift-storage","Request.Name":"ocs-external-storagecluster","StorageCluster":{"name":"ocs-external-storagecluster","namespace":"openshift-storage"},"error":"some StorageClasses were skipped while waiting for pre-requisites to be met: [ocs-external-storagecluster-ceph-rbd-rados-namespace]","stacktrace":"github.com/red-hat-storage/ocs-operator/v4/controllers/storagecluster.(*ocsExternalResources).ensureCreated\n\t/workspace/controllers/storagecluster/external_resources.go:271\ngithub.com/red-hat-storage/ocs-operator/v4/controllers/storagecluster.(*StorageClusterReconciler).reconcilePhases\n\t/workspace/controllers/storagecluster/reconcile.go:436\ngithub.com/red-hat-storage/ocs-operator/v4/controllers/storagecluster.(*StorageClusterReconciler).Reconcile\n\t/workspace/controllers/storagecluster/reconcile.go:175\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227"}
{"level":"info","ts":"2023-11-27T18:36:39Z","logger":"controllers.StorageCluster","msg":"Reconciling external StorageCluster.","Request.Namespace":"openshift-storage","Request.Name":"ocs-external-storagecluster","StorageCluster":{"name":"ocs-external-storagecluster","namespace":"openshift-storage"}}
{"level":"info","ts":"2023-11-27T18:36:39Z","logger":"controllers.StorageCluster","msg":"Monitoring Information found. Monitoring will be enabled on the external cluster.","Request.Namespace":"openshift-storage","Request.Name":"ocs-external-storagecluster","CephCluster":{"name":"ocs-external-storagecluster","namespace":"openshift-storage"}}
W1127 18:36:39.916244       1 client_config.go:618] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
{"level":"info","ts":"2023-11-27T18:36:39Z","logger":"controllers.StorageCluster","msg":"prometheus rules deployed","Request.Namespace":"openshift-storage","Request.Name":"ocs-external-storagecluster","CephCluster":{"name":"ocs-external-storagecluster-cephcluster","namespace":"openshift-storage"}}
{"level":"info","ts":"2023-11-27T18:36:39Z","logger":"controllers.StorageCluster","msg":"No component operator reported negatively.","Request.Namespace":"openshift-storage","Request.Name":"ocs-external-storagecluster"}