Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Steps #2

Open
3 of 7 tasks
kahlil opened this issue Sep 3, 2015 · 6 comments
Open
3 of 7 tasks

Next Steps #2

kahlil opened this issue Sep 3, 2015 · 6 comments

Comments

@kahlil
Copy link
Contributor

kahlil commented Sep 3, 2015

Dear @reactivepod/reactivists & @reactivepod/owners:

First of all big ups to @wbinnssmith for putting this together!
Second of all how can we clean this up and get it shipped to Chrome App Store?

Has any of you tested this Chrome plugin?
Can we get some QA done here and maybe fix it up so that it can be published into the Chrome App Store?

I'd suggest a few todos here:

  • change repo name to Gittens by popular vote
  • introduce esnow chore: use esnow #3
  • introduce linting Cleanup #5
  • introduce tests
  • fix any bugs that occur
  • add icons
  • publish to Chrome app store

Any thoughts, suggestions?

@yves-s
Copy link

yves-s commented Sep 3, 2015

Jepp, a name change would be better. I vote for gittens and I suggest gittycat

@wbinnssmith
Copy link
Contributor

Gittens sounds great!

The idea behind the current name is that "git" has always meant an
unpleasant person and the extension "ungits" the page by turning them into
kittens.

Re: cleaning it up: yeah, it's missing a number of things like logos,
descriptions and other manifest-things. Also I attempted to keep the
dependencies minimal (no jquery, react, backbone or the like) but if it
gets any more complex it might be worth it. One small alternative that will
fit in nicely with the browserify builds is the stuff from @npm-dom

Of course, I've been meaning to move this to esnow since it seems like the
perfect candidate for that.

On Thu, Sep 3, 2015, 1:36 AM Yves Schleich [email protected] wrote:

Jepp, a name change would be better. I vote for gittens and I suggest
gittycat


Reply to this email directly or view it on GitHub
#2 (comment).

@kahlil
Copy link
Contributor Author

kahlil commented Sep 3, 2015

The idea behind the current name is that "git" has always meant an
unpleasant person and the extension "ungits" the page by turning them into
kittens.

Yeah I got that once @ollicle posted that Wiki link in the Slack chat. If you want to keep that name then you'd have to put an explanation in the README though I would say. I really just didn't get it at first.

Can you make a list of things that need to be done to clean the thing up?
Can you actually update my issue and put more check list items in there?

@ollicle
Copy link
Contributor

ollicle commented Sep 3, 2015 via email

@andreruffert
Copy link
Member

I've tested the Chrome plugins functionality real quick and everything looks 👍

andreruffert added a commit that referenced this issue Sep 5, 2015
* separate source map files
* uglify files

> #2

chore: use uglify files
@kahlil
Copy link
Contributor Author

kahlil commented Sep 6, 2015

Just changed the name to Gittens. It had the most 👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants