Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Nitro Modules (and nitrogen) #1397

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mrousavy
Copy link
Member

πŸ“ Why & how

I added Nitro Modules and nitrogen to this list.

There are already two libraries using both Nitro Modules and Nitrogen in the directory.

βœ… Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

@mrousavy
Copy link
Member Author

btw @Simek how does one library get the "Recommended" library badge? I wonder if react-native-mmkv or react-native-vision-camera are eligible for that... πŸ‘€

Copy link
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mrousavy, thanks for the new additions! πŸ‘

Can you move the newly added libraries at the end of file? We use that for one of sort orders, it also helps a bit with discoverability:


When it come to the "Recommended" flag, we have a definition of the criterion on the scoring page:

Screenshot 2024-11-25 at 19 49 24

But to shed a bit more light into the topic, we did not re-evaluated internally for a longer while to which libraries we should add, or from which to remove the status. Because with time, we saw more confusion on the directory users side, than benefits which this flags could potentially give.

We have some plans in mind related that one hand-picked status, since a lot things have changed since we initially added it. Stay tuned for some follow ups in the future! πŸ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants