Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing yarn.lock #1755

Open
cseas opened this issue Oct 27, 2023 · 2 comments
Open

Consider removing yarn.lock #1755

cseas opened this issue Oct 27, 2023 · 2 comments
Labels
enhancement New feature or request P2 Not important

Comments

@cseas
Copy link
Member

cseas commented Oct 27, 2023

npm/documentation#810

tldr:

Committing package-lock.json to the source code version control means that the project maintainers and CI systems will use a specific version of dependencies that may or may not match those defined in package.json. Because package-lock.json cannot be added to NPM registry (by design; see NPM shrinkwrap), projects that depend on a project that uses package-lock.json will themselves use package.json to resolve project's dependencies, i.e. what works for project maintainers/ CI systems might not work when the project is used as a dependency.

@divyanshkul
Copy link

Can I work on this?
CC: @cseas

@chaitanyadeorukhkar chaitanyadeorukhkar added the enhancement New feature or request label Oct 30, 2023
@cseas
Copy link
Member Author

cseas commented Oct 30, 2023

Waiting for the Blade team to analyse and consider the suggestion.

With lock file

  • you get a reproducible development environment but your consumers will almost always get a different package tree than what Blade is developed on.

Without lock file

  • development environment won't be reproducible 1:1 at all times but the package tree of Blade devs will be much closer to what consumers actually install.

The third option is to enforce the library's package tree by shipping a shrinkwrap file. But yarn doesn't support that.

@saurabhdaware saurabhdaware added the P2 Not important label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Not important
Projects
None yet
Development

No branches or pull requests

4 participants