Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update topology spread constraints for custom worker pools #2633

Conversation

TessaIO
Copy link
Contributor

@TessaIO TessaIO commented Dec 10, 2024

Why are these changes needed?

It fixes the topology spread constraints for custom worker pools

Related issue number

Closes #2632

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(
Screenshot 2024-12-11 at 00 00 46 Screenshot 2024-12-11 at 00 00 54

@TessaIO TessaIO force-pushed the fix-workergroups-topology-spread-constraints branch from dc569bb to 2b2b49d Compare December 10, 2024 23:07
@TessaIO
Copy link
Contributor Author

TessaIO commented Dec 10, 2024

/cc @kevin85421

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kevin85421 kevin85421 merged commit 9cd80cc into ray-project:master Dec 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Helm Custom worker groups topology spread constraints don't work
2 participants