[RayService][Refactor] Change the ServeConfigs to nested map #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rueian would you mind reviewing the PR? |
rueian
reviewed
Dec 2, 2024
| cacheKey := rayServiceInstance.Namespace + "/" + rayServiceInstance.Name | ||
| serveConfigs, exist := r.ServeConfigs.Get(cacheKey) | ||
| if !exist { | ||
| return "" |
There was a problem hiding this comment.
Is it possible that the config is indeed an empty string?
There was a problem hiding this comment.
Fixed in 040d475. Only cache the serveConfig when it is not empty.
kevin85421
approved these changes
Dec 4, 2024
| @@ -57,7 +57,7 @@ type RayServiceReconciler struct { | |||
| Recorder record.EventRecorder | |||
| // Currently, the Ray dashboard doesn't cache the Serve deployment config. | |||
| // To avoid reapplying the same config repeatedly, cache the config in this map. | |||
| ServeConfigs cmap.ConcurrentMap[string, string] | |||
| ServeConfigs cmap.ConcurrentMap[string, cmap.ConcurrentMap[string, string]] | |||
There was a problem hiding this comment.
Can you add a comment to explain the definitions of key and value?
There was a problem hiding this comment.
Added in b2cb82a
Closes: ray-project#2550 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#2550 Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
feature/#2550-serveconfig-ds-change
branch
from
040d475 to
ca8482b
Compare
Closes: ray-project#2550 Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
feature/#2550-serveconfig-ds-change
branch
from
ca8482b to
b2cb82a
Compare
kevin85421
approved these changes
Dec 4, 2024
Closes: ray-project#2550 Signed-off-by: Chi-Sheng Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See the description in the corresponding issue for details.
Related issue number
Closes: #2550
Checks