[RayService][Refactor] Change the data structure of ServeConfigs to avoid iterating the whole map

[kevin85421]

Search before asking

• I had searched in the issues and found no similar feature requirement.

Description

kuberay/ray-operator/controllers/ray/rayservice_controller.go

Lines 517 to 535 in f3353b2

	func (r *RayServiceReconciler) cleanUpServeConfigCache(ctx context.Context, rayServiceInstance *rayv1.RayService) {
	logger := ctrl.LoggerFrom(ctx)
	activeConfigKey := r.generateConfigKey(rayServiceInstance, rayServiceInstance.Status.ActiveServiceStatus.RayClusterName)
	pendingConfigKey := r.generateConfigKey(rayServiceInstance, rayServiceInstance.Status.PendingServiceStatus.RayClusterName)
	configPrefix := r.generateConfigKeyPrefix(rayServiceInstance)
	// Clean up RayCluster serve deployment configs.
	for key := range r.ServeConfigs.Items() {
	if key == activeConfigKey || key == pendingConfigKey {
	continue
	}
	if !strings.HasPrefix(key, configPrefix) {
	// Skip configs owned by other RayService Instance.
	continue
	}
	logger.Info("cleanUpServeConfigCache", "activeConfigKey", activeConfigKey, "pendingConfigKey", pendingConfigKey, "remove key", key)
	r.ServeConfigs.Remove(key)
	}
	}

Currently, the key of ServeConfigs is ${RAY_SERVICE_NAMESPACE}/${RAY_SERVICE_NAME}/${RAY_CLUSTER_NAME}. Hence, cleanUpServeConfigCache needs to iterate the whole map to find the keys which belong to this RayService CR.

Maybe we can change the key to ${RAY_SERVICE_NAMESPACE}/${RAY_SERVICE_NAME}/, and the value to a map where the key is ${RAY_CLUSTER_NAME} and the value is ServeConfigV2.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!