Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] kuberay/apiserver deployment via helm doesn't respect https serving for swagger-ui #2542

Open
2 tasks done
metasyn opened this issue Nov 14, 2024 · 0 comments · May be fixed by #2543
Open
2 tasks done

[Bug] kuberay/apiserver deployment via helm doesn't respect https serving for swagger-ui #2542

metasyn opened this issue Nov 14, 2024 · 0 comments · May be fixed by #2543
Labels
bug Something isn't working triage

Comments

@metasyn
Copy link

metasyn commented Nov 14, 2024 •
edited
Loading

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

apiserver

What happened + What you expected to happen

I deployed the kuberay api server behind an HTTPS enforced proxy. However, this breaks the swagger UI

Screenshot 2024-11-14 at 11 48 14 AM

Reproduction script

See here:
https://github.com/ray-project/kuberay/pull/1410/files#diff-a50ea34a29966148610d48f80f87b358d8f0042d414a478daf816162493d2e2d

I think we need to use window.location.protocol instead of hardcoding http:

Anything else

This is persistent

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@metasyn metasyn added bug Something isn't working triage labels Nov 14, 2024
@metasyn metasyn linked a pull request Nov 14, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update swagger-initializer.js metasyn/kuberay
1 participant
@metasyn