Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WsServer.php #1035

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update WsServer.php #1035

wants to merge 1 commit into from

Conversation

Zagicien
Copy link

@Zagicien Zagicien commented Aug 9, 2023

Hi,
it won't works without it if json protocol is asked.

Exemple with this code in javascript :
const socket = new WebSocket('wss://exemple.com', ["json"]);

it won't works without it if json protocol is asked.
@szado
Copy link

szado commented Aug 10, 2023

This change is unnecessary. To declare supported websocket subprotocols simply implement getSubProtocols() from WsServerInterface in your server component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants