reboot hosts handler occurs without changes

[xunholy]

Details

The hosts should only need to be reboot for significant changes that require them to be restarted.

Currently, without any changes they'll still trigger into a host reboot which isn't intended.

[issue-label-bot]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[xunholy]

After doing several trials what seems to be the offending notify that triggers the host reboot handler is the following task:

- name: install log2ram
  command: /bin/sh ./install.sh
  args:
    chdir: '/opt/log2ram'
  register: log2ram
  changed_when: '"Reboot to activate log2ram" in log2ram.stdout'
  notify: reboot hosts

[xunholy]

Tested consecutive installs for log2ram to determine if it was idempotent, however, each install will still require a restart or at least prompt the user that a restart is required.

pi@k8s-master-01:/opt/log2ram$ sudo /bin/sh ./install.sh
#####         Reboot to activate log2ram         #####
##### edit /etc/log2ram.conf to configure options ####
pi@k8s-master-01:/opt/log2ram$ sudo /bin/sh ./install.sh
#####         Reboot to activate log2ram         #####
##### edit /etc/log2ram.conf to configure options ####

[xunholy]

This might potentially be solved if we installed with the recommended official method rather than running the shell script as described here: https://github.com/azlux/log2ram#with-apt-recommended