Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finished_at_start/end job filters #111

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

Xeitor
Copy link
Contributor

@Xeitor Xeitor commented Apr 5, 2024

Changelog

  • added finished_at range filter support for jobs

Issue: #30

PD: I'll split the different filters in different PRs for easier review

@Xeitor Xeitor marked this pull request as draft April 5, 2024 21:57
@Xeitor Xeitor marked this pull request as ready for review April 7, 2024 14:38
@Xeitor
Copy link
Contributor Author

Xeitor commented Apr 9, 2024

Hi @rosa! Don't mean to bother you but in case you missed this this PR is ready for review :)

@rosa
Copy link
Member

rosa commented Apr 10, 2024

@Xeitor thanks for letting me know, I'll try to review soon!

@Xeitor
Copy link
Contributor Author

Xeitor commented May 15, 2024

Hi @rosa, hope you are doing great

Sorry to bother you, wanted to know if you were able to take a look at the PR :)

@Xeitor Xeitor requested a review from rosa August 18, 2024 13:34
@rosa
Copy link
Member

rosa commented Sep 13, 2024

Hey @Xeitor, so sorry about this huge delay! I haven't had time to focus on Mission Control lately, but it's definitely in the plans for October, I need to spend a week or so just working on all pending PRs and missing features 😳

@Xeitor
Copy link
Contributor Author

Xeitor commented Sep 25, 2024

Hey @Xeitor, so sorry about this huge delay! I haven't had time to focus on Mission Control lately, but it's definitely in the plans for October, I need to spend a week or so just working on all pending PRs and missing features 😳

for sure no problem

@rosa
Copy link
Member

rosa commented Nov 4, 2024

Hey @Xeitor, I'm finally back with Mission Control. Are you still interested in working on this one? I'd understand if not, given how long it's been, so sorry about that! If you're no longer interested, I'm happy to take it from here.

@Xeitor
Copy link
Contributor Author

Xeitor commented Nov 8, 2024

hi @rosa, glad to have you back. For sure, no worries, I 'll take a look at the comments in the next days

@MacLove13 MacLove13 mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants