Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to exclude specific methods #11

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ldez
Copy link
Collaborator

@ldez ldez commented Nov 27, 2024

This is a draft of a proposal.

I used a glob-based expression, but it can be a regular expression or something else.

Related to #8 (comment)
Fixes #9

analyzer.go Outdated Show resolved Hide resolved
@ldez ldez force-pushed the feat/exclude-option branch 2 times, most recently from fb627f6 to 169323e Compare November 27, 2024 21:48
@ldez ldez force-pushed the feat/exclude-option branch 2 times, most recently from f4240a2 to c4b2743 Compare November 27, 2024 22:04
@ldez ldez force-pushed the feat/exclude-option branch from c4b2743 to 01c7fa6 Compare November 27, 2024 22:05
@raeperd
Copy link
Owner

raeperd commented Dec 1, 2024

To me, *.MarshalYAML or MarshalYAML does the same.
So maybe we can safely remove glob pattern, and simplifies config with exact match only. (ex type.MarshalYAML)

@ldez
Copy link
Collaborator Author

ldez commented Dec 1, 2024

To me, *.MarshalYAML or MarshalYAML does the same

Not really because the type element is required, MarshalYAML will match nothing.

Currently not inside this PR but the wildcard allows doing this: type.* (ignore a type).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitelist driver.Valuer interface
3 participants