Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with newer code from nowplaypadgen project #8

Open
2 of 3 tasks
paraenggu opened this issue Jan 27, 2019 · 1 comment · May be fixed by #132
Open
2 of 3 tasks

Merge with newer code from nowplaypadgen project #8

paraenggu opened this issue Jan 27, 2019 · 1 comment · May be fixed by #132

Comments

@paraenggu
Copy link
Member

paraenggu commented Jan 27, 2019

radiorabe/nowplaypadgen provides modern replacements for the Show, Track and TimePeriod objects (including tests and docs). Those could be integrated and replace the current objects.


@hairmare
Copy link
Member

From what I've seen some of the linked modules seem to cover a more narrow use case than what we are currently doing in nowplaying.

IMO there is still some refactoring to be done to make this replacement possible. Mainly the input parts are what still needs some work as those don't have much test coverage yet.
I'm also not quite sure on how we would proceed on the nowplaypadgen side of things. Do we want it to stay viable as a standalone module in it's own right. I certainly think it might be of interest to a larger audience if it stays standalone.

We also need to consider how we would like to handle our core python object models going forward. I've been considering a solution based on something like a rabe.commons python module that is primarily there to contain some very simple and abstract base modules but that is most certainly overkill.

@hairmare hairmare linked a pull request Dec 26, 2021 that will close this issue
3 tasks
@hairmare hairmare moved this to In Progress in songticker Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants