Swap readr for data.table as creator of TSV #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I tweaked myself to ensure that CI/CD is run. Should we perhaps consider offering both ways of creating the CSV files, and perhaps make the data.table way opt-in for now? |
|
Something's not quite right yet with the tests, could you please take a look? |
|
Ok I'll see if I understand whats going on. |
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
krlmlr
reviewed
Apr 1, 2024
| @@ -61,23 +61,23 @@ db_append_table <- function(conn, name, value, warn_factor = TRUE, safe = TRUE, | |||
| sql <- paste0( | |||
| "LOAD DATA LOCAL INFILE ", dbQuoteString(conn, path), "\n", | |||
| "IGNORE\n", | |||
| "FIELDS TERMINATED BY ", dbQuoteString(conn, "\t"), "\n", | |||
There was a problem hiding this comment.
Perhaps:
Suggested change
| "FIELDS TERMINATED BY ", dbQuoteString(conn, "\t"), "\n", | |
| "FIELDS TERMINATED BY ", dbQuoteString(conn, "\\t"), "\n", |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #270.