Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same case on all value lists #385

Open
rbovard opened this issue Sep 4, 2024 · 4 comments
Open

Use the same case on all value lists #385

rbovard opened this issue Sep 4, 2024 · 4 comments
Labels
Datamodel Datamodel related Enhancement

Comments

@rbovard
Copy link
Contributor

rbovard commented Sep 4, 2024

There is a lack of case consistency for values lists.

Some examples:

  • Mixed case qwat_vl.status:
    • autre
    • inconnu
    • à déterminer
    • En service
    • Hors service
    • Désaffecté
    • Abandonné
    • Détruit
    • Projet planifie
    • Fictif
    • Projet en execution
  • Lower case qwat_vl.source_type:
    • autre
    • inconnu
    • à déterminer
    • captage eau lac
    • captage eau nappe
    • captage eau source
    • captage eau rivière
  • Upper case qwat_vl.precision:
    • Autre
    • Inconnu
    • À déterminer
    • Imprécis
    • Précis
    • Localisé
    • Digitalisé
@ponceta
Copy link
Member

ponceta commented Sep 4, 2024

Since all theses values have unique codes, we could easily provide a uniformed case french translation.
This will require a delta since it is considered as a datamodel upgrade.

@ponceta ponceta added Enhancement Datamodel Datamodel related labels Sep 4, 2024
@rbovard
Copy link
Contributor Author

rbovard commented Sep 4, 2024

It's not only for french, but yes.

Now you need to decide wich way go: uppercase or lowercase ;)

@ponceta
Copy link
Member

ponceta commented Sep 6, 2024

It's mainly a community decision and some user comfort, as these rely on value codes.

Here is a sample of reaches in TEKSI wastewater :

image

Here is the equivalent for pipes in QWAT :

image

But what I find hard to decide is when translating, do we care more about the data and its conversion into other systems like geoportals -> approach of having lowercase with underscore is the best (with language like german that will still have some mandatory uppercases.)

Or do we care more about the user (geomatician, GIS operator) feeling and how he likes his fields to be displayed.

For materials in QWAT in pully we had to create a custom displayname to fit these user needs.

This can have a large impact for any user who uses the solution because they will have to adapt this everywhere theses attributes are used. (geoportals, FME, DWG, ...)

@ponceta
Copy link
Member

ponceta commented Sep 6, 2024

I would fix it like this for now (as it will surely change when SSIGE releases its datamodel) :

  • Mixed case qwat_vl.status:
    • Autre
    • Inconnu
    • À déterminer
    • En service
    • Hors service
    • Désaffecté
    • Abandonné
    • Détruit
    • Projet planifie
    • Fictif
    • Projet en execution
  • Lower case qwat_vl.source_type:
    • Autre
    • Inconnu
    • À déterminer
    • Captage eau lac
    • Captage eau nappe
    • Captage eau source
    • Captage eau rivière
  • Upper case qwat_vl.precision:
    • Autre
    • Inconnu
    • À déterminer
    • Imprécis
    • Précis
    • Localisé
    • Digitalisé

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datamodel Datamodel related Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants