Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Qblox classifier #1030

Open
Edoardo-Pedicillo opened this issue Oct 28, 2024 · 1 comment
Open

Remove Qblox classifier #1030

Edoardo-Pedicillo opened this issue Oct 28, 2024 · 1 comment

Comments

@Edoardo-Pedicillo
Copy link
Contributor

Originally posted by @alecandido in #1025 (review)

@Edoardo-Pedicillo Edoardo-Pedicillo mentioned this issue Oct 28, 2024
8 tasks
@alecandido
Copy link
Member

Thanks for the issue!

Do you remember why we have both a qubit and Qblox fit?

It came out after a discussion with the lab people to benchmark with the qubit fit method. For sure we can remove it, I will open an issue

I'm not sure whether it's worth to remove qblox_fit on its own, since in a sense it's simpler.
I will take some time to inspect if all the operations in the qubit_fit are required, and whether we can simplify it to make it closer to the qblox_fit.

(i.e. I assume they are more or less equivalent, other than the more extensive output of the qubit_fit, and I will attempt a merge)

In any case, better to keep it separate from #1025. I.e. the issue is worth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants