Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual_z phases #1026

Open
DavidSarlle opened this issue Oct 25, 2024 · 1 comment
Open

virtual_z phases #1026

DavidSarlle opened this issue Oct 25, 2024 · 1 comment
Assignees

Comments

@DavidSarlle
Copy link
Contributor

Seems that virtual_z_phases (probabilities) has an error in the routine and the virtual_z defined in te experiment is not applied. The same routine with signal works as expected. The problm is in line 249.
It should be:
theta - data.vphases[ord_pair][target_q]

instead of:
theta

@Edoardo-Pedicillo
Copy link
Contributor

This issue is solved by #1017, which has already been merged into main. Could you please test it again with the main branch and show that everything is working as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants