Merge pull request #997 from qiboteam/fix_rabi_2D_fit

Fix bug in rabi 2D fit
qiboteam · Oct 7, 2024 · 2a7062c · 2a7062c
2 parents c77f563 + 3377b87
commit 2a7062c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/qibocal/protocols/rabi/amplitude_frequency.py b/src/qibocal/protocols/rabi/amplitude_frequency.py
@@ -161,7 +161,7 @@ def _fit(data: RabiAmplitudeFreqData) -> RabiAmplitudeFrequencyResults:
         x = (amps - x_min) / (x_max - x_min)
         y = (y - y_min) / (y_max - y_min)
 
-        period = fallback_period(guess_period(amps, y))
+        period = fallback_period(guess_period(x, y))
         pguess = [0.5, 0.5, period, 0]
 
         try:

diff --git a/src/qibocal/protocols/rabi/amplitude_frequency_signal.py b/src/qibocal/protocols/rabi/amplitude_frequency_signal.py
@@ -185,7 +185,7 @@ def _fit(data: RabiAmplitudeFreqSignalData) -> RabiAmplitudeFrequencySignalResul
         x = (amps - x_min) / (x_max - x_min)
         y = (y - y_min) / (y_max - y_min)
 
-        period = fallback_period(guess_period(amps, y))
+        period = fallback_period(guess_period(x, y))
         pguess = [0.5, 0.5, period, 0]
 
         try:

diff --git a/src/qibocal/protocols/rabi/length_frequency.py b/src/qibocal/protocols/rabi/length_frequency.py
@@ -155,7 +155,7 @@ def _fit(data: RabiLengthFreqData) -> RabiLengthFrequencyResults:
         x = (durations - x_min) / (x_max - x_min)
         y = (y - y_min) / (y_max - y_min)
 
-        period = fallback_period(guess_period(durations, y))
+        period = fallback_period(guess_period(x, y))
         pguess = [0, np.sign(y[0]) * 0.5, period, 0, 0]
 
         try:

diff --git a/src/qibocal/protocols/rabi/length_frequency_signal.py b/src/qibocal/protocols/rabi/length_frequency_signal.py
@@ -179,7 +179,7 @@ def _fit(data: RabiLengthFreqSignalData) -> RabiLengthFrequencySignalResults:
         x = (durations - x_min) / (x_max - x_min)
         y = (y - y_min) / (y_max - y_min)
 
-        period = fallback_period(guess_period(durations, y))
+        period = fallback_period(guess_period(x, y))
         pguess = [0, np.sign(y[0]) * 0.5, period, 0, 0]
 
         try: