Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.0 a couple issues on first attempt to use #78

Open
remdragon opened this issue Dec 17, 2022 · 1 comment
Open

0.5.0 a couple issues on first attempt to use #78

remdragon opened this issue Dec 17, 2022 · 1 comment

Comments

@remdragon
Copy link

  1. trying to use this on Windows is producing bad EOL in output file. This is because the file is opened binary on read and pulls in '\r\n' but then the file is opened as text on output so ends up writing '\r\r\n' to the output file

  2. need to support older versions of python but the following code:
    from typing_extensions import AsyncIterator
    gets transformed to the invalid:
    from typing_extensions import Iterator

  3. unasync output files are invalid if they use tabbed indentation. Source tabs are getting replaced with a single space on some but not all lines. Actual error trying to run a converted file:

  File "C:\cvs\gravitas_v1\incpy\esl_sync.py", line 48
    if value is None:
                     ^
IndentationError: unindent does not match any outer indentation level
  1. a simple way to run this by hand (setup.py is overkill for my needs) to convert a file to another file in the same directory. In my case I want to convert 'esl_async.py' to 'esl_sync.py' in the same folder. This is what I did in order to get this far:
# stdlib imports:
import os
from pathlib import Path
import sys

# 3rd-party imports:
import unasync # pip install unasync
from unasync import std_tokenize, _tokenize, _makedirs_existok

def _untokenize(tokens):
	return "".join(
		space + '\n' if tokval == '\r\n' else space + tokval
		for space, tokval in tokens
	)

class Rule( unasync.Rule ):
	def __init__( self, fromdir, todir, suffix ) -> None:
		self.suffix = suffix
		super().__init__( fromdir, todir )
	
	def _outfilepath( self, filepath ):
		path = Path( self.todir ).absolute() / f'{Path(filepath).stem}{self.suffix}.py'
		#assert False, f'{filepath=} {path=} {os.path.dirname(str(path))=}'
		return str( path )
	
	def _unasync_file( self, filepath ):
		with open(filepath, "rb") as f:
			write_kwargs = {}
			if sys.version_info[0] >= 3:
				encoding, _ = std_tokenize.detect_encoding(f.readline)
				write_kwargs["encoding"] = encoding
				f.seek(0)
			tokens = _tokenize(f)
			tokens = self._unasync_tokens(tokens)
			result = _untokenize(tokens)
			outfilepath = self._outfilepath( filepath )
			_makedirs_existok(os.path.dirname(outfilepath))
			with open(outfilepath, "w", **write_kwargs) as f:
				print(result, file=f, end="")

rule = Rule( '.', '.', '_sync' )
rule._unasync_file( 'esl.py' )
@pquentin
Copy link
Member

Thanks! As you can tell development has slowed down but I would be happy to review self-contained pull requests that fix those issue one at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants