Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Autoimport database and indexing #740

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bagel897
Copy link
Contributor

@bagel897 bagel897 commented Jan 10, 2024

Description

The main autoimport class has gotten quite large. This PR simplifies it by splitting out a Database object. It also adds an index function to unify indexing between the different methods (resource, gen_cache, modules_cache)

Future Proposals

This can be iterated on in future PRs

  • Simplify the constructor in the Database class (Combine with create_connection/setup_db??)
  • Split out the searching component somehow?
  • Split the indexing component? (IE, a core indexer with the _index function, a package discovery mechanism, and the rope API)

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md
  • I have made corresponding changes to user documentation for new features
  • I have made corresponding changes to library documentation for API changes

@bagel897 bagel897 changed the title Refactor Autoimport into components Refactor Autoimport database and indexing Jan 10, 2024
@lieryan
Copy link
Member

lieryan commented Jan 22, 2024

Hi @bagel897, is this PR ready for review or are you still working on it? If it's ready to review, can you please move it out of draft?

@bagel897
Copy link
Contributor Author

Still have stuff to work on and will need to incorporate #516 once its merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants