Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform release is not a version-like marker #552

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

platform release is not a version-like marker #552

wants to merge 6 commits into from

Commits on Jan 30, 2023

  1. platform release is not a version-like marker 

    Version like markers are validated against PEP-440. This allows things
like '1.0.0' and disallows things like '1.8.0_u60'. However, this is
very valid in platform_release, as described in
[PEP-508](https://peps.python.org/pep-0508/#environment-markers)
which gives samples `3.14.1-x86_64-linode39, 14.5.0, 1.8.0_51`.

platform_release should be a normal marker, which I think allows for
equality checking only.

This fixes #7418 where I was guided towards this solution.
    @j-baker
    j-baker committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    001a3b4 View commit details
    Browse the repository at this point in the history

  2. add explicit test for this behaviour

    @j-baker
    j-baker committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    1f59eb2 View commit details
    Browse the repository at this point in the history

  3. Move unit test closer to original problem test to make more clear if … 

    …anyone git blames this
    @j-baker
    j-baker committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    99a466d View commit details
    Browse the repository at this point in the history

  4. comment

    @j-baker
    j-baker committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7685cc0 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @j-baker
    pre-commit-ci[bot] authored and j-baker committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    eca89a7 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Update test_markers.py

    @j-baker
    j-baker authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    334ef55 View commit details
    Browse the repository at this point in the history