[helm.v4.Chart] Proposal: option to deploy helm hooks #3285
+56
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
@EronWright you're the only one in the blame of Would you accept it ? And if so do you want me to iterate on it or someone @ pulumi ? |
EronWright
requested changes
Oct 31, 2024
There was a problem hiding this comment.
I outlined here the technical challenges in truly supporting hook resources. I believe it is worse to implement hooks wrongly than to not support them at all. We have the Release resource for cases where chart compatibility is an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
helm.v3.Chartignored thehelm.sh/hook*annotations but still deployed the resources.The
helm.v4.Chartresource skips the hooks. This is mentioned in the blog but not in the docs BTW.In this PR I propose to make it configurable so a pulumi user can decide to deploy resources, ignoring the hooks.
The end goal being that helm.v4.Chart comes to feature parity with helm.v3.Chart so we can all move all our charts to v4.
Note that:
CONTRIBUTING.mdtells me to install stuff in/optwhich is not happening, so I did not run the tests locallyRelated issues (optional)
Fixes #3284