Fix warning for Automation API inline programs #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
force-pushed
the
justin/auto_warning
branch
from
d60de10
to
8e9de25
Compare
Frassle
approved these changes
Nov 15, 2024
justinvp
force-pushed
the
justin/auto_warning
branch
from
8e9de25
to
bb146bb
Compare
When using Automation API inline programs with Pulumi CLI v3.132.0 and later, a warning is emitted because the language host for .NET inline programs does not implement the `GetPluginInfo` RPC. This change adds an implementation for `GetPluginInfo`, which avoids the warning. The implementation returns "1.0.0" for the version, which matches Node.js and Go. Separately, we should consider updating the CLI to not emit the warning to users when the language host does not implement `GetPluginInfo`.
justinvp
force-pushed
the
justin/auto_warning
branch
from
bb146bb
to
2c8fafb
Compare
Merged
|
This PR has been shipped in release v3.70.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Automation API inline programs with Pulumi CLI v3.132.0 and later, a warning is emitted because the language host for .NET inline programs does not implement the
GetPluginInfoRPC (from pulumi/pulumi#17216).This change adds an implementation for
GetPluginInfo, which avoids the warning. The implementation returns"1.0.0"for the version, which matches Node.js and Go (though, Python returns an empty string).Separately, we should consider updating the CLI to not emit the warning to users when the language host does not implement
GetPluginInfo.Fixes #369