Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From bot token to per workflow generated token #1098

Closed

Conversation

ringods
Copy link
Member

@ringods ringods commented Oct 8, 2024

Fixes: #963, #1087

Moving from a central PULUMI_BOT_TOKEN to the Github Actions permissions block makes the workflows reusable for third party providers too. The generated GITHUB_TOKEN secret in each workflow instance will receive elevated permissions based on the permissions configuration block.

Docs on permission:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token

Results of testing the changes on third-party providers:

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on first pass. We should pick an internal provider to roll this out to and verify all the key workflows work: upgrade-provider through to release.

@ringods
Copy link
Member Author

ringods commented Oct 8, 2024

This PR contains too much at once. So chopping it up.

Replacements:

Will close this PR when all functionality is submitted as separate PRs.

@ringods ringods force-pushed the from-bot-token-to-per-workflow-generated-token branch 2 times, most recently from 4c6d66a to a061deb Compare October 9, 2024 15:26
@ringods ringods force-pushed the from-bot-token-to-per-workflow-generated-token branch from cd862f8 to 4b44085 Compare October 15, 2024 12:55
@ringods ringods closed this Oct 31, 2024
@ringods ringods deleted the from-bot-token-to-per-workflow-generated-token branch October 31, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that the "Check Upstream" job uses the Github Token from the enclosing repo, not a Org scoped token
2 participants