Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Coverage Data job cannot find upstream go.mod #1160

Closed
guineveresaenger opened this issue Nov 26, 2024 · 2 comments
Closed

Generate Coverage Data job cannot find upstream go.mod #1160

guineveresaenger opened this issue Nov 26, 2024 · 2 comments
Assignees
@danielrbradley
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@guineveresaenger
Copy link
Contributor

Example failures:

Since Makefile changes in PRs such as this one, we're seeing the generate coverage data job not having the ./upstream submodule available.

https://github.com/pulumi/pulumi-okta/actions/runs/12024901877/job/33569497516
https://github.com/pulumi/pulumi-gcp/actions/runs/12025368466/job/33568908896
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 26, 2024
@blampe
Copy link
Contributor

blampe commented Nov 26, 2024 •
edited
Loading

@guineveresaenger maybe try updating workflows again, Daniel just tweaked this in #1157

Edit: Trying that here pulumi/pulumi-gcp#2691

@flostadler flostadler mentioned this issue Nov 27, 2024
Open
@danielrbradley danielrbradley removed the needs-triage Needs attention from the triage team label Nov 27, 2024
@danielrbradley danielrbradley self-assigned this Nov 27, 2024
@danielrbradley danielrbradley added kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed labels Nov 27, 2024
@danielrbradley
Copy link
Member

Yes, it looks like this was solved by #1157 and was rolled out last night

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielrbradley danielrbradley

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@danielrbradley @blampe @guineveresaenger @pulumi-bot