Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify default provider-ci config in code #1146

Open
blampe opened this issue Nov 15, 2024 · 1 comment
Open

Specify default provider-ci config in code #1146

blampe opened this issue Nov 15, 2024 · 1 comment
Labels
kind/engineering Work that is not visible to an external user

Comments

@blampe
Copy link
Contributor

blampe commented Nov 15, 2024

We currently specify config defaults here

We can instead specify them in code here:

https://github.com/pulumi/ci-mgmt/blob/6de05d16ad63eeffbd88aeb476030381ffdb13b6/provider-ci/internal/pkg/config.go

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 15, 2024
@iwahbe iwahbe added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Nov 18, 2024
@iwahbe
Copy link
Member

iwahbe commented Nov 18, 2024

I think that specifying them in the defaults file is a bit clearer. If there was a way in Go to specify a config format that was self-documenting and could generate a default file, then I'd go with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

3 participants