Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure interactive controls are not nested #1004

Open
zaymasood opened this issue Nov 29, 2021 · 2 comments
Open

Ensure interactive controls are not nested #1004

zaymasood opened this issue Nov 29, 2021 · 2 comments

Comments

@zaymasood
Copy link
Contributor

Errors in spec/features/accessibility_spec.rb

accessibility when visiting search results page complies with WCAG

nested-interactive: Ensure interactive controls are not nested (serious)
https://dequeuniversity.com/rules/axe/4.3/nested-interactive?application=axeAPI
The following 4 nodes violate this rule:
           
       Selector: #access
       HTML: <button class="btn btn-default btn-filter dropdown-toggle" type="button" id="access" data-toggle="dropdown" data-flip="false" aria-haspopup="true" aria-expanded="true"><span><a data-no-turbolink="true" href="#">Access</a></span><span class="caret"></span></button>
       Fix any of the following:
       - Element has focusable descendants
               
       Selector: #institution
       HTML: <button class="btn btn-default btn-filter dropdown-toggle" type="button" id="institution" data-toggle="dropdown" data-flip="false" aria-haspopup="true" aria-expanded="true"><span><a data-no-turbolink="true" href="#">Institution</a></span><span class="caret"></span></button>
       Fix any of the following:
       - Element has focusable descendants
               
       Selector: #format
       HTML: <button class="btn btn-default btn-filter dropdown-toggle" type="button" id="format" data-toggle="dropdown" data-flip="false" aria-haspopup="true" aria-expanded="true"><span><a data-no-turbolink="true" href="#">Format</a></span><span class="caret"></span></button>
       Fix any of the following:
       - Element has focusable descendants
               
       Selector: #subject
       HTML: <button class="btn btn-default btn-filter dropdown-toggle" type="button" id="subject" data-toggle="dropdown" data-flip="false" aria-haspopup="true" aria-expanded="true"><span><a data-no-turbolink="true" href="#">Subject</a></span><span class="caret"></span></button>
       Fix any of the following:
       - Element has focusable descendants
@tpendragon
Copy link
Contributor

We're going to take a quick look. If it looks like it's going to be a lot of work to fix we'll deprioritize.

@thanyabegum
Copy link

This is something that would be best addressed upstream, or may be resolved after upgrading GeoBlacklight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants