Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wings: Allow Customizing Docker Arguments #5238

Open
1 task done
Kale-Ko opened this issue Oct 30, 2024 · 2 comments
Open
1 task done

wings: Allow Customizing Docker Arguments #5238

Kale-Ko opened this issue Oct 30, 2024 · 2 comments
Labels
feature request A request for a new feature.

Comments

@Kale-Ko
Copy link

Kale-Ko commented Oct 30, 2024

Is there an existing feature request for this?

  • I have searched the existing issues before opening this feature request.

Describe the feature you would like to see.

It would be super useful if it where possible to modify the arguments passed to Docker when creating a container. Currently I am running into an issue where the /tmp directory is being filled up by a program. I attempted to mount a directory on the host to /tmp but it was overwritten by the default tmpfs /tmp dir.

Describe the solution you'd like.

Somewhere in the wings config a template string or just trimmed down arguments list (from what is actually passed to docker) that can be modified to fit a users needs.

Additional context to this request.

There was also a time when I wanted to change the docker arguments to add the NET_RAW capability to a container but I end up finding a workaround for that.

@Kale-Ko Kale-Ko added the feature request A request for a new feature. label Oct 30, 2024
@danny6167
Copy link
Member

The code really doesn't work like this. There isn't a string to template.
We interact with the docker API directly. We aren't executing docker cli commands

@Kale-Ko
Copy link
Author

Kale-Ko commented Oct 30, 2024

It's JSON is it not? You could just merge the defaults and the user provided JSON together.

I guess in fairness that is easier said than done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request for a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants