Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing GaugeWithExemplar #122

Open
bobrik opened this issue Jan 5, 2023 · 2 comments
Open

Missing GaugeWithExemplar #122

bobrik opened this issue Jan 5, 2023 · 2 comments

Comments

@bobrik
Copy link
Contributor

bobrik commented Jan 5, 2023

I want to have a GaugeWithExemplar that adds an exemplar whenever gauge derivates from zero. The actual use-case is making a flamegraph and putting it into the exemplar label, so that it can be easily found.

It seems like it would mostly be a copy of CounterWithExemplar, so I'm happy to make a PR if this makes sense.
@bobrik
Copy link
Contributor Author

bobrik commented Jan 16, 2023

Apparently there's prometheus/OpenMetrics#241.

@mxinden
Copy link
Member

mxinden commented Jan 18, 2023

Thanks for the input. No opinion here, i.e. not opposed to merging a patch. Just want to be consistent with Prometheus and/or OpenMetrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobrik @mxinden