Don't redraw scan chart before first scan #957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "Show Scan Plot" is toggled on before the first scan has completed, or the scan plot is open and the user navigates away from the Auto-RX tab and back before the first scan has completed, then an error occurs and the scan plot renders incorrectly:
This happens because
scan_chart_latest_timestamp
is not defined until the first scan has completed, butredraw_scan_chart
(which is invoked when the scan chart is opened, or when the user navigates back from another tab) attempts to use it anyway.To fix the problem, I've added a check so that
redraw_scan_chart
exits early ifscan_chart_latest_timestamp
is not yet defined.