Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hld nits #94

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Hld nits #94

merged 10 commits into from
Jul 26, 2024

Conversation

lrvideckis
Copy link
Member

@lrvideckis lrvideckis commented Jul 13, 2024 •
edited
Loading

I decided to add back depth array cuz it makes the logic of kth_on_path simpler/cleaner, and also easier to test

cameroncuster
cameroncuster approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@cameroncuster cameroncuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

@cameroncuster cameroncuster merged commit d3a29c7 into main Jul 26, 2024
3 checks passed
@cameroncuster cameroncuster deleted the hld_nits branch July 26, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameroncuster cameroncuster cameroncuster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrvideckis @cameroncuster