Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate solidity deps #388

Open
shaspitz opened this issue Sep 6, 2024 · 0 comments
Open

Consolidate solidity deps #388

shaspitz opened this issue Sep 6, 2024 · 0 comments

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Sep 6, 2024

See https://github.com/primev/mev-commit/blob/main/contracts/remappings.txt, we reference https://github.com/OpenZeppelin/openzeppelin-contracts twice. Once directly from lib/openzeppelin-contracts/ and once as a dep of a dep via lib/openzeppelin-contracts-upgradeable/lib/openzeppelin-contracts/contracts/. This is not good practice as it's unclear which version of the dep we're using in various locations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant