Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containsCurrentItem State Not Reset in NavList Component. #4721

Open
Hanskrogh opened this issue Jul 7, 2024 · 1 comment · May be fixed by #4722
Open

containsCurrentItem State Not Reset in NavList Component. #4721

Hanskrogh opened this issue Jul 7, 2024 · 1 comment · May be fixed by #4722
Labels
bug Something isn't working component: NavList react

Comments

@Hanskrogh
Copy link

Description

When the navlist component includes a subnav and there is a current item within that subnav, the containsCurrentItem state is not being reset to false. As a result, the visual indication of the current item remains displayed until the component is fully re-rendered.

Steps to reproduce

  1. Add a subnav within the navlist component.
  2. Ensure there is a current item within the subnav.
  3. Observe that the containsCurrentItem state remains true even after the current item is no longer relevant.

Version

36.24.0

Browser

Chrome

@Hanskrogh Hanskrogh added the bug Something isn't working label Jul 7, 2024
@Hanskrogh Hanskrogh linked a pull request Jul 7, 2024 that will close this issue
12 tasks
@broccolinisoup
Copy link
Member

Hello @TylerJDev 👋 Would you be able to review the PR #4722 that @Hanskrogh pushed? Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: NavList react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants