Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor links in various documentation component previews are broken #491

Open
jeremyong opened this issue Apr 13, 2023 · 3 comments
Open
Assignees

Comments

@jeremyong
Copy link

Describe the bug
Visiting the documentation at primer.css, many of the component previews control navigation via anchor links in some manner, and attempting to navigate to the anchor ultimately reloads the site in the preview as opposed to working as intended.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://primer.style/css/components/tabnav
  2. Click on any of the tabs
  3. Observe the issue

Expected behavior
Components should behave in the preview as you would expect during development and production.

Screenshots
image
After clicking, "Bar tab", this becomes:
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version 111.0.5563.147

Additional context
Other components like the subnav also seem to exhibit this issue, but I didn't go through to identify every instance.

@devjiwonchoi
Copy link

The documentation of this repo is not maintained anymore.
Please raise any documentation-specific pull requests in primer.style/design.

@howdyray howdyray transferred this issue from primer/css May 22, 2023
@janbrasna
Copy link
Contributor

This was true for old Gatsby docs.

Now the same in React/Storybook https://primer.style/components/tab-nav/react/alpha does something even worse;] — reloading the whole iframe.html? to top location. Interestingly the Rails examples do have links to view-components-storybook.eastus.cloudapp.azure.com* but they are inactive, so can be clicked etc. with no reloading.

@tallys
Copy link
Contributor

tallys commented Jun 25, 2024

@emilybrick let's add this to our next docs discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants