PR approval process

[facastagnini]

Since this is a community maintained project we should have a basic approval process for PRs.

I would like to propose that we need a majority of maintainers' OK before merging

I am submitting this proposal looking for agree or disagree comments and remarks, please participate.

CC current maintainers: @paulmelnikow @johnpneumann

NOTE: Branching from #26 to keep that thread clean.

[paulmelnikow]

We could also say "a majority of maintainers". That would reduce the risk in bringing on new people at this stage, and make sure as the team grows they are staying aware of what's happening.

[facastagnini]

Agree, I updated the proposal in the first comment to keep it simple.

I think this definition should be approved by everyone in the team. At this moment we just need @johnpneumann to agree. Please let us know your thoughts.

[johnpneumann]

When we say "majority" are we saying a "senate majority" (an actual majority of the maintainers - ex. 11 out of 20 maintainers agree) or are we just saying that we need a "simple majority" (more people in agreement than disagreement - 4 out of 7 of the maintainers that commented on the PR)?

[facastagnini]

I think that we need at least two maintainers to agree with a change, no matter how many users ask for a change, we are supposed to be the benevolent gate keepers right? is that our role as maintainers?

[paulmelnikow]

I'd say senate majority, 2 of 3 maintainers, 3 of 5 maintainers, 4 of 7.

If the team grows significantly we could adopt a new approach. At this stage what the project most needs is a committed group of leaders who are contributing on a consistent basis. A senate majority will help keep us engaged.

[johnpneumann]

@facastagnini - I wasn't insinuating that it was just a majority vote, but a majority vote by maintainers specifically. If anyone can merge anything based on just any vote count, then we'll be Pitbull playing a show in Kodiak, Alaska.

[facastagnini]

ok, we have an agreement 👍