-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spider Database #18
base: master
Are you sure you want to change the base?
Conversation
- Connect to spider examples database
engine_params: {} | ||
metadata_cache_timeout: {} | ||
schemas_allowed_for_csv_upload: [] | ||
uuid: 4a8e60d1-307f-aa55-9a38-894f2ee7c58b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this randomly generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generated it using my new BFF ChatGPT. I also could generate one "in superset" by manually connecting the DB and exporting it so I can get a uuid
from it if that's preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think we just need to verify the name
databases/Spider.yaml
Outdated
@@ -0,0 +1,16 @@ | |||
database_name: spider_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about the name. I think Max had a different idea about how to name these so that it would make more sense for someone who does not know what Spider is. Something on the line "ai_assist_examples" as far as I remember
- Change DB name to ai_assist_examples
@Antonio-RiveroMartnez don't forget to create a pr with superset shell to point to the latest public examples after you merge this. |
Oh yeah! I need to ask @geido and the rest if we want to create these DBs automatically for users still or wait. But will keep this in mind. Thanks @sadpandajoe |
NOTE: We need to hold merging this until shell changes have been deployed to production.