Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spider Database #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Antonio-RiveroMartnez
Copy link

@Antonio-RiveroMartnez Antonio-RiveroMartnez commented Jun 29, 2023

  • Connect to spider examples database

NOTE: We need to hold merging this until shell changes have been deployed to production.

- Connect to spider examples database
@Antonio-RiveroMartnez Antonio-RiveroMartnez changed the title feat: Spider DB feat: Spider Database Jun 29, 2023
@Antonio-RiveroMartnez Antonio-RiveroMartnez marked this pull request as draft June 29, 2023 05:52
@Antonio-RiveroMartnez Antonio-RiveroMartnez marked this pull request as ready for review July 5, 2023 15:15
engine_params: {}
metadata_cache_timeout: {}
schemas_allowed_for_csv_upload: []
uuid: 4a8e60d1-307f-aa55-9a38-894f2ee7c58b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this randomly generated?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated it using my new BFF ChatGPT. I also could generate one "in superset" by manually connecting the DB and exporting it so I can get a uuid from it if that's preferred.

Copy link

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we just need to verify the name

@@ -0,0 +1,16 @@
database_name: spider_examples
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the name. I think Max had a different idea about how to name these so that it would make more sense for someone who does not know what Spider is. Something on the line "ai_assist_examples" as far as I remember

- Change DB name to ai_assist_examples
@sadpandajoe
Copy link
Contributor

@Antonio-RiveroMartnez don't forget to create a pr with superset shell to point to the latest public examples after you merge this.

@Antonio-RiveroMartnez
Copy link
Author

@Antonio-RiveroMartnez don't forget to create a pr with superset shell to point to the latest public examples after you merge this.

Oh yeah! I need to ask @geido and the rest if we want to create these DBs automatically for users still or wait. But will keep this in mind. Thanks @sadpandajoe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants