Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android SDK should rely on ext.prebid.type on selectong the rendering engine #769

Open
YuriyVelichkoPI opened this issue Jun 18, 2024 · 0 comments

Comments

@YuriyVelichkoPI
Copy link
Contributor

Motivation

SDK should be aligned with Prebid ecosystem.

Background

Android SDK determines the bid format by checking the content of the adm filed. If it contains VAST tag the ad will be treated as video, otherwise as banner.

However, looking at the PBS codebase, we can see that the logic of determining the bid format is the responsibility of each particular bidder. There are different approaches to determining the bid type, and some implementations are pretty complex.

So, it is not right to rely on internal SDK logic when the bidder knows the actual value better.

Objectives

The BidResponse.isVideo() function should check the value of ext.prebid.type response field instead of analyzing the content of the ad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage
Development

No branches or pull requests

1 participant