Fix wrong url pattern for Yieldlab #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The domain 'ad.yieldlab.net' is used for all our calls. So if there is a delivery / matching / tracking done on the website, the latency is added up for all the calls and the addon gives the wrong impression that yieldlab's header bidding took a long time to respond. "ad.yieldlab.net/yp/" is the actual endpoint for solely the header bidding.
|
@matthewlane @jsnellbaker What do i need to do to get this merged? We are still getting support requests because of this issue on a regular basis. Thanks! |
mkendall07
approved these changes
Jun 17, 2019
|
@jsnellbaker when you get a chance can you merge and release this? |
jsnellbaker
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The domain 'ad.yieldlab.net' is used for all our calls. So if there is a delivery / matching / tracking done on the website, the latency is added up for all the calls and the addon gives the wrong impression that yieldlab's header bidding took a long time to respond. "ad.yieldlab.net/yp/" is the actual endpoint for solely the header bidding.
This was already raised as an issue 9 month ago:
#11