Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: generalize formhub instance address #11

Open
zmyao88 opened this issue Jul 7, 2014 · 5 comments
Open

Feature request: generalize formhub instance address #11

zmyao88 opened this issue Jul 7, 2014 · 5 comments

Comments

@zmyao88
Copy link

zmyao88 commented Jul 7, 2014

Current version hard coded Formhub's url, but now users can host their own instances.
It would be important to have user defined url/ ip address option with default points to "formhub.org".

@prabhasp
Copy link
Owner

prabhasp commented Jul 7, 2014

Do you have time to do a pull request? Hardly on the computer till later
next week.
On Jul 7, 2014 12:39 PM, "Zaiming Yao" [email protected] wrote:

Current version hard coded Formhub's url, but now users can host their own
instances.
It would be important to have user defined url/ ip address option with
default points to "formhub.org".

Reply to this email directly or view it on GitHub
#11.

@zmyao88
Copy link
Author

zmyao88 commented Jul 7, 2014

sure, I'll do a quick fix on SEL-Columbia Branch with one liner, and leave
it to you for further modification if necessary.

On Mon, Jul 7, 2014 at 1:04 PM, prabhasp [email protected] wrote:

Do you have time to do a pull request? Hardly on the computer till later
next week.
On Jul 7, 2014 12:39 PM, "Zaiming Yao" [email protected] wrote:

Current version hard coded Formhub's url, but now users can host their
own
instances.
It would be important to have user defined url/ ip address option with
default points to "formhub.org".

Reply to this email directly or view it on GitHub
#11.


Reply to this email directly or view it on GitHub
#11 (comment).

@ericpgreen
Copy link

Glad to find this fix. I just set up my own instance and need to specify the URL. Until this is merged, could either of you suggest a method for overwriting the existing formhubDownload() function with @zmyao88's fix?

@zmyao88
Copy link
Author

zmyao88 commented Jul 18, 2014

Hey Eric,

Please refer to this repo: https://github.com/SEL-Columbia/formhub.R/,
which incorporated my quick fix.

Let me know if there's any bug.

Thanks and enjoy,
Zaiming

On Fri, Jul 18, 2014 at 3:36 PM, Eric Green [email protected]
wrote:

Glad to find this fix. I just set up my own instance and need to specify
the URL. Until this is merged, could either of you suggest a method for
overwriting the existing formhubDownload() function with @zmyao88
https://github.com/zmyao88's fix?


Reply to this email directly or view it on GitHub
#11 (comment).

@ericpgreen
Copy link

Thanks, Zaiming. Much appreciated.

On July 18, 2014 at 3:48:18 PM, Zaiming Yao ([email protected]) wrote:

Hey Eric,

Please refer to this repo: https://github.com/SEL-Columbia/formhub.R/,
which incorporated my quick fix.

Let me know if there's any bug.

Thanks and enjoy,
Zaiming

On Fri, Jul 18, 2014 at 3:36 PM, Eric Green [email protected]
wrote:

Glad to find this fix. I just set up my own instance and need to specify
the URL. Until this is merged, could either of you suggest a method for
overwriting the existing formhubDownload() function with @zmyao88
https://github.com/zmyao88's fix?


Reply to this email directly or view it on GitHub
#11 (comment).


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants