-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libs for linux-arm64 and linux-arm #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/smoogipoo/SDL3-CS/actions/runs/9099250769
macOS builds seem to have broken, it's not immediately obvious why but it's fine on master so it has to be related to this PR (https://github.com/smoogipoo/SDL3-CS/actions/runs/9099367179).
https://github.com/kvnp/SDL3-CS/actions/runs/9134571638 It finally works now. The problem was that the quotes in the flags were previously ignored when passing them via expressions to the cmake calls. After the change to pass them as env vars, they were no longer ignored, causing these "not separated tokens" errors. This only became apparent after I tried to build via ninja, see the following log snippets. Output without NinjaArgument not separated from preceding token by whitespace. This warning is for project developers. Use -Wno-dev to suppress it.CMake Warning (dev) at build/CMakeFiles/SDL3-shared.dir/DependInfo.cmake:11: Argument not separated from preceding token by whitespace. CMake Warning (dev) at build/CMakeFiles/SDL3-shared.dir/DependInfo.cmake:11: Argument not separated from preceding token by whitespace. CMake Warning (dev) at build/CMakeFiles/SDL3-shared.dir/DependInfo.cmake:12: Argument not separated from preceding token by whitespace. CMake Warning (dev) at build/CMakeFiles/SDL3-shared.dir/DependInfo.cmake:12: Output with Ninja[1/226] Building C object 'CMakeFiles/SDL3-shared.dir/cmake_pch_"x86_64".h.pch' FAILED: CMakeFiles/SDL3-shared.dir/cmake_pch_"x86_64".h.pch /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -DDLL_EXPORT -DSDL_BUILD_MAJOR_VERSION=3 -DSDL_BUILD_MICRO_VERSION=2 -DSDL_BUILD_MINOR_VERSION=1 -DUSING_GENERATED_CONFIG_H -I/Users/runner/work/SDL3-CS/SDL3-CS/build/include-config-release -I/Users/runner/work/SDL3-CS/SDL3-CS/build/include -I/Users/runner/work/SDL3-CS/SDL3-CS/include -I/Users/runner/work/SDL3-CS/SDL3-CS/src -I/Users/runner/work/SDL3-CS/SDL3-CS/include/SDL3 -O3 -DNDEBUG -arch "x86_64" -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -mmacosx-version-min="10.14" -fPIC -fvisibility=hidden -Wall -Wundef -fno-strict-aliasing -Wdocumentation -Wdocumentation-unknown-command -fcomment-block-commands=threadsafety -Wshadow -Wno-unused-local-typedefs -Wimplicit-fallthrough -fcolor-diagnostics -idirafter/Users/runner/work/SDL3-CS/SDL3-CS/src/video/khronos -Wno-error=deprecated-declarations -D_REENTRANT -fobjc-arc -Winvalid-pch -Xclang -emit-pch -Xclang -include -Xclang /Users/runner/work/SDL3-CS/SDL3-CS/build/CMakeFiles/SDL3-shared.dir/cmake_pch_\"x86_64\".h -x c-header -MD -MT 'CMakeFiles/SDL3-shared.dir/cmake_pch_"x86_64".h.pch' -MF CMakeFiles/SDL3-shared.dir/cmake_pch_\"x86_64\".h.pch.d -o 'CMakeFiles/SDL3-shared.dir/cmake_pch_"x86_64".h.pch' -c '/Users/runner/work/SDL3-CS/SDL3-CS/build/CMakeFiles/SDL3-shared.dir/cmake_pch_"x86_64".h.c' :1:90: warning: extra tokens at end of #include directive [-Wextra-tokens] #include "/Users/runner/work/SDL3-CS/SDL3-CS/build/CMakeFiles/SDL3-shared.dir/cmake_pch_"x86_64".h" ^ // :1:10: fatal error: '/Users/runner/work/SDL3-CS/SDL3-CS/build/CMakeFiles/SDL3-shared.dir/cmake_pch_' file not found #include "/Users/runner/work/SDL3-CS/SDL3-CS/build/CMakeFiles/SDL3-shared.dir/cmake_pch_"x86_64".h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning and 1 error generated. [2/226] Building OBJC object CMakeFiles/SDL3-shared.dir/src/file/cocoa/SDL_iostreambundlesupport.m.o [3/226] Building OBJC object CMakeFiles/SDL3-shared.dir/src/misc/macos/SDL_sysurl.m.o [4/226] Building OBJC object CMakeFiles/SDL3-shared.dir/src/camera/coremedia/SDL_camera_coremedia.m.o [5/226] Building C object CMakeFiles/SDL3-shared.dir/src/dynapi/SDL_dynapi.c.o ninja: build stopped: subcommand failed. |
Thanks a lot! |
Continues the work of #55.