Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

House number not added to street values #98

Open
MartinL1983 opened this issue Nov 29, 2024 · 3 comments
Open

House number not added to street values #98

MartinL1983 opened this issue Nov 29, 2024 · 3 comments

Comments

@MartinL1983
Copy link

Hi,

We are using the NL postcode check and we have noticed that the house number is not being added to the street address part. In our setup we have need customers to add street + house number in the same field (shipping-address-fieldset.street.0)

The issue seems to be on lines 65 to 71 in postcode-nl/api-magento2-module/view/frontend/web/js/form/components/checkout/address-autofill-nl.js

The same issue could also be with international addresses, but as we don't use that we are unable to confirm this.

@MartinL1983 MartinL1983 changed the title Housenumber not added to street values House number not added to street values Nov 29, 2024
@JerrySmidt
Copy link
Contributor

Hello,

If Magento is configured to use one street line, then our module should already put street + house number + house number addition in one field.

The number of street lines can be configured at Stores -> Configuration -> Customer Configuration -> Name and Address Options -> Number of Lines in a Street Address.

@MartinL1983
Copy link
Author

@JerrySmidt

Thank you for your reply. But this is an incorrect approach to this issue as one, like in the Netherlands, can have two address fields. One for street + house number and a second for additional information. Having two fields does not automatically mean the house number should be added to the second field.

@JerrySmidt
Copy link
Contributor

Thanks Martin, that makes sense. This should probably be the default way to fill in the street values. I'll see if I can fix this in the next version.

JerrySmidt added a commit to JerrySmidt/PostcodeNl_Api_Magento2 that referenced this issue Dec 11, 2024


* Javascript settings now (only) available via checkoutProvider.
* Get config value or flag by path alias in StoreConfigHelper.
* Increase version to 3.5.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants