Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle up the linting-requirements in tox with the pre-commit hook #139

Open
Tracked by #136
pnkraemer opened this issue Jan 26, 2024 · 0 comments
Open
Tracked by #136

Comments

@pnkraemer
Copy link
Owner

pnkraemer commented Jan 26, 2024

Unify formatting, linting, and continuous integration.
There should only be one way of linting the code, not two (pre-commit and tox).

The likely solution would be to move all formatting and linting to the pre-commit hook and to call pre-commit run --all-files in the GitHub Action. It might also be time to move to Ruff instead of pylint+black+isort. Remember to update the developer guidelines.

@pnkraemer pnkraemer changed the title Unify formatting, linting, and continuous integration by bundling up black, isort, pylint, etc., with the pre-commit hook. The likely solution would be to move all formatting and linting to the pre-commit hook and to call pre-commit run --all-files in the GitHub Action. It might also be time to move to Ruff instead of pylint+black+isort. Remember to update the developer guidelines. Unify formatting, linting, and continuous integration by bundling up black, isort, pylint, etc., with the pre-commit hook Jan 26, 2024
@pnkraemer pnkraemer changed the title Unify formatting, linting, and continuous integration by bundling up black, isort, pylint, etc., with the pre-commit hook Unify formatting, linting, and continuous integration by bundling up the linting-requirements in tox with the pre-commit hook Jan 26, 2024
@pnkraemer pnkraemer changed the title Unify formatting, linting, and continuous integration by bundling up the linting-requirements in tox with the pre-commit hook Bundle up the linting-requirements in tox with the pre-commit hook Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant