Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing/Search Block Variants for Page/News Item/Event/File #4765

Open
tisto opened this issue May 15, 2023 · 8 comments · May be fixed by #6055
Open

Listing/Search Block Variants for Page/News Item/Event/File #4765

tisto opened this issue May 15, 2023 · 8 comments · May be fixed by #6055

Comments

@tisto
Copy link
Member

tisto commented May 15, 2023

PLIP (Plone Improvement Proposal)

Responsible Persons

Proposer: Timo Stollenwerk

Seconder:

Abstract

Currently Plone ships with the following listing/search block variants:

Screenshot 2024-05-13 at 15 58 39

Create new listing block variants that show the following content objects:

  • page
  • news item
  • event
  • file

in a different way (tbd).

Listing Block Variants:

  • List (rename existing variant "Default" to "List") - ID: list
  • List with images (rename existing variant "Summary") - ID: list_with_images
  • Grid (2 columns) (rename "Grid" to "Grid (2 columns)") - ID: grid_2_columns
  • Grid (3 columns) - ID: grid_3_columns
  • Grid with images (2 columns) - ID: grid_with_images_2_columns
  • Grid with images (3 columns) - ID: grid_with_images_3_columns

Items render based on the content type:

  • Page (title, description, image)
  • News (title, description, image, effective_date)
  • Event (title, description, image, start_date, end_date)

Motivation

Assumptions

Proposal & Implementation

Deliverables

Risks

Participants

@tisto
Copy link
Member Author

tisto commented Sep 10, 2023

Notes Beethoven Sprint 2023:

Listing Block Variants:

  • List
  • List with images
  • Columns -> Grid
  • Columns with images -> Grid with images

We should avoid using “Default” as an option, since it doesn’t really explain/describe the actual view.

Remember to use the same grammatical category inside the same options group.
(Standard and Grid don’t work together, since the first one is an adjective and the second one a noun.)

13FF30AF-6193-4105-8215-0617D626D166_1_105_c

B0474542-044E-468D-8EBD-C6080F545BD2_1_105_c

@plone plone locked and limited conversation to collaborators Feb 14, 2024
@tisto
Copy link
Member Author

tisto commented Mar 2, 2024

@danalvrz since you stepped up to work on this at Beethoven Sprint, if I recall correctly, I was wondering if you could imagine putting this on the agenda for the upcoming Axolote Sprint? cc @davisagli @sneridagh @ericof

@davisagli
Copy link
Member

@tisto We need to discuss how to handle backwards compatibility for existing listing and search blocks.

@tisto tisto self-assigned this May 13, 2024
@djay
Copy link
Member

djay commented May 14, 2024

Just a note that an alternative is replacing the listing block with the more flexible idea of a repeater block ( half of #4478).
The variation for the listing are just the arrangement, ie grid, vs list. But instead of variations for how each item is rendered, instead a real block type is selected and each item is rendered as a block. (but not blocks that can be added or removed. read-only blocks).
For example the teaser block or a card block could be what is repeated.
This means the integrator has to do far less work creating variations for listing blocks, and instead can just change a setting to say which of the custom block types should be able to be selected as repeatable (and what listing metadata will get mapped to which repeatable block field). And all the work going into creating variations for that teaser block then get to be reused on the listing/repeater block without effort.

@tisto
Copy link
Member Author

tisto commented May 15, 2024

@djay thanks for the pointer. I get the idea of re-using existing rendering options we have instead of creating new ones. I think this is beyond the scope of this PLIP.

@stevepiercy
Copy link
Collaborator

From my comment plone/plone.de#59 (comment), I suggested to amend the Event to include the following:

  • event start time with time zone
  • event end time with time zone
  • location (text, such as city, state, and country, URL to a map service or online meeting service, or longitude and latitude)

@iFlameing
Copy link
Member

Ongoing PR: #6055

@tisto
Copy link
Member Author

tisto commented Sep 6, 2024

@plone/volto-team please review this PLIP proposal. We will ask for a review of the ongoing PR soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Ready
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants