Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moment.js is a legacy project, Temporal is coming #2392

Closed
pnicolli opened this issue May 3, 2021 · 4 comments
Closed

Moment.js is a legacy project, Temporal is coming #2392

pnicolli opened this issue May 3, 2021 · 4 comments

Comments

@pnicolli
Copy link
Contributor

pnicolli commented May 3, 2021

Moment.js is a legacy project, it is officially been stated. react-dates, which we are using, among other components we have, depends on it, and we also use it in other places.

Temporal will be the new standard, it got to Stage 3. I still have to look further into it, but I wanted to raise awareness on the subject and possibly collect some comments.
Due to this new standard, migrating to other famous libraries like date-fns is probably not a good idea at this time, so unless we find out something interesting, we might want to keep an eye on these new standard and check how the world will adapt.

One possibly interesting issue on the subject (at least the latest comments):
react-dates/react-dates#208

@pnicolli
Copy link
Contributor Author

@plone/volto-team we can probably close this since we base our future on react-aria-components which does not revolve around momentjs anymore, while Temporal is STILL stage 3 after 3 years :/

@stevepiercy
Copy link
Collaborator

react-dates requires excessive clicks to go to a specific year or month. Try picking your birthdate. Forget it! I'll just type it in. The date picker we choose should make it easy to select a year or month without all the clickety-clicks, tappity-taps, and swipe-ity-swipes.

Without question, yeet moment.js from the stack.

I could not find how to navigate to specific months and years in react-aria-components DatePicker, other than using excessive clicks or keyboard entry. Did I miss something?

In any case, yes, paste a link to the issue or PR regarding the move to react-aria-components, then close this issue.

References:

@davisagli
Copy link
Member

@stevepiercy
Copy link
Collaborator

@davisagli thanks! I updated the PLIP's "Proposal and Implementation" section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants